Skip to content

Upgrading plugin dependencies to include 'Critical' severity#25

Merged
kerenr-jfrog merged 24 commits intojfrog:masterfrom
kerenr-jfrog:fix_critical_severity_issue
Dec 31, 2024
Merged

Upgrading plugin dependencies to include 'Critical' severity#25
kerenr-jfrog merged 24 commits intojfrog:masterfrom
kerenr-jfrog:fix_critical_severity_issue

Conversation

@kerenr-jfrog
Copy link
Copy Markdown
Contributor

@kerenr-jfrog kerenr-jfrog commented Dec 23, 2024 •
edited
Loading

  • Upgraded ide-plugins-common dependency to version 1.6.1
  • Code refactored according to the new dependency implementation.
  • Critical severity was added.
  • Added exclusion pattern for folders.
  • Severity icons have been changed and added icon for the 'critical' severity.
  • Using GradleTreeBuilder for building Gradle dependency tree.
  • Using NpmTreeBuilder for building Npm dependency tree.

@kerenr-jfrog kerenr-jfrog changed the title Fix critical severity issue Upgrading plugin dependencies to include 'Critical' severity Dec 24, 2024
@kerenr-jfrog kerenr-jfrog added the dependencies Pull requests that update a dependency file label Dec 24, 2024
@kerenr-jfrog kerenr-jfrog self-assigned this Dec 24, 2024
@kerenr-jfrog kerenr-jfrog marked this pull request as ready for review December 24, 2024 15:57
hadarshjfrog
hadarshjfrog reviewed Dec 25, 2024
View reviewed changes
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/GradleScanManager.java Outdated
hadarshjfrog
hadarshjfrog reviewed Dec 25, 2024
View reviewed changes
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/ScanManager.java Outdated
hadarshjfrog
hadarshjfrog reviewed Dec 25, 2024
View reviewed changes
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/utils/ProjectsMap.java
hadarshjfrog
hadarshjfrog reviewed Dec 25, 2024
View reviewed changes
Copy link
Copy Markdown

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments overview:

  1. why is the rename between DependenciesTree to DependencyTree ?
  2. Unused @overrides
  3. Empty spaces and breaklines

attiasas
attiasas reviewed Dec 26, 2024
View reviewed changes
Copy link
Copy Markdown

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

  • Why only to v1.6.1 and not latest?
  • Can't we use the severity icons we use in all other applications?

Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/NpmScanManager.java
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/NpmScanManager.java
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/MavenScanManager.java
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/GradleScanManager.java Outdated
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/scan/GradleScanManager.java Outdated
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/configuration/PreferenceConstants.java Outdated
Comment thread bundle/src/main/java/com/jfrog/ide/eclipse/ui/issues/ComponentIssueTable.java Outdated
@kerenr-jfrog kerenr-jfrog merged commit 3ce2fa3 into jfrog:master Dec 31, 2024
@kerenr-jfrog kerenr-jfrog deleted the fix_critical_severity_issue branch February 2, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas attiasas left review comments

@NatalieJFrog NatalieJFrog Awaiting requested review from NatalieJFrog

+1 more reviewer

@hadarshjfrog hadarshjfrog hadarshjfrog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kerenr-jfrog kerenr-jfrog

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kerenr-jfrog @attiasas @hadarshjfrog